Adding Deep.BI analytics to AMP #25757
Conversation
Follow up of ampproject#25128 (fixing CLA - "cannot verify e-mail" issue) Intent-to-implement ticket: ampproject#25070
|
Adding @ mentions as reviewers. |
| 'ampUserLocation': 'AMP_USER_LOCATION', | ||
| 'ampUserLocationPoll': 'AMP_USER_LOCATION_POLL', |
There was a problem hiding this comment.
Why are these getting added?
There was a problem hiding this comment.
I must have taken an older version of the file.
Fixed! Thanks!
Delete old, improper lines. As in: ampproject#25757 (comment)
|
Thank you very much @micajuine-ho!!! Hello @zhouyx, I hope we'll be going with our analytics for AMP soon now :) |
|
Hello @calebcordry, @micajuine-ho, @zhouyx , As far as I can see @zhouyx is on her vacation or otherwise is not available at the moment. Could you please @calebcordry and @micajuine-ho revise the review request to @zhouyx? |
There was a problem hiding this comment.
Thank you @pkalinowski and @micajuine-ho
LGTM. As @micajuine-ho pointed out in the old thread. Please let users know that requestOrigin will only accepts an absolute URL, and only the origin of the URL will be used. https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/amp-analytics.md#request-origin for more information.
Thanks
|
PR merged. Thanks |
* Adding Deep.BI analytics to AMP Follow up of ampproject#25128 (fixing CLA - "cannot verify e-mail" issue) Intent-to-implement ticket: ampproject#25070 * Update vendors.js Delete old, improper lines. As in: ampproject#25757 (comment)
Follow up of #25128
(fixing CLA - "cannot verify e-mail" issue)
Intent-to-implement ticket: #25070
@micajuine-ho @zhouyx - Thank you for your input. I hope this time it will get smoother :)