Fix reloading for 'latest' extension versions #25763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Nov 25, 2019
| const regex = /^(.*)\/(.*)-([0-9.]+)\.js$/i; | ||
| const matches = scriptUrl.match(regex); | ||
|
|
||
| const matches = scriptUrl.match(/^(.*)\/(.*)-([0-9.]+|latest)\.js$/i); |
There was a problem hiding this comment.
Nit: We can drop the ^(.*)\/ entirely
There was a problem hiding this comment.
Don't we at least need the \/ to separate the extension ID? E.g. https://cdn.ampproject.org/v0/amp-foo-latest.js.
dreamofabear
commented
Dec 2, 2019
| const matches = this.win.document.head./*OK*/ querySelectorAll( | ||
| `script[src*="/${extensionId}-"]` + modifier | ||
| ); | ||
| const matcher = new RegExp(`${extensionId}-\\d`); |
There was a problem hiding this comment.
@gmajoulet This used to match local builds like amp-foo-0.1.max.js, but parseExtensionUrl does not. Need to update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25751.