Fixes amp-analytics iframeTransport regression. #25917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndering, the iframeTransport should be injected in the parent window instead of iframe window.
lannka
changed the title
dreamofabear
approved these changes
Dec 6, 2019
dvoytenko
suggested changes
Dec 6, 2019
| // This behavior will be changed by ampdoc-fie launch. | ||
| // TODO: this will be a blocker to launch ampdoc-fie. | ||
| // We should find a different way to get the parent win in case of FIE. | ||
| this.getAmpDoc().win, |
There was a problem hiding this comment.
Can you instead use getTopWindow(this.win)? The getTopWindow is defined in the service.js.
There was a problem hiding this comment.
Shall we do in a separate PR as this PR will be cherry picked?
Or you think it's safe enough?
There was a problem hiding this comment.
Ok to move to a separate PR.
dvoytenko
approved these changes
Dec 6, 2019
lannka
added a commit
that referenced
this pull request
Dec 6, 2019
* Add an example for botguard * Fixes amp-analytics iframeTransport regression. In the case of FIE rendering, the iframeTransport should be injected in the parent window instead of iframe window. * more comments
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Add an example for botguard * Fixes amp-analytics iframeTransport regression. In the case of FIE rendering, the iframeTransport should be injected in the parent window instead of iframe window. * more comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of FIE rendering, the iframeTransport should be injected in the parent window instead of iframe window.
The regression was introduced here:
https://github.com/ampproject/amphtml/pull/25769/files#r354981761