Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update amp-a4a-format.md to include amp-selector. #26025

Merged
merged 1 commit into from Jan 29, 2020
Merged

Update amp-a4a-format.md to include amp-selector. #26025

merged 1 commit into from Jan 29, 2020

Conversation

jyn15
Copy link
Contributor

@jyn15 jyn15 commented Dec 14, 2019 •
edited

Resolves #25773: add amp-selector to the list of allowed extensions.

@jyn15 jyn15 requested review from rsimha and removed request for keithwrightbos January 29, 2020 00:46
@rsimha rsimha requested review from keithwrightbos and removed request for rsimha January 29, 2020 00:50
@rsimha
Copy link
Contributor

rsimha commented Jan 29, 2020 •
edited

Change looks straightforward, but I don't have ownership of this file. Can someone from @ampproject/wg-ads look at this?

@powerivq powerivq merged commit 97a2ec7 into ampproject:master Jan 29, 2020
@powerivq
Copy link
Contributor

Thanks!

@jyn15 jyn15 deleted the doc branch February 25, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

@keithwrightbos keithwrightbos Awaiting requested review from keithwrightbos

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow amp-selector in AMP4ADS
5 participants
@jyn15 @rsimha @powerivq @googlebot @ampprojectbot