Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] amp inline gallery captions #26076

Closed

Conversation

sparhami
Copy link

@sparhami sparhami commented Dec 18, 2019

This PR is a WIP, but is not in a fully working state yet. There are a few things that need to be fixed in addition to code clean up. The initial state of this PR can be seen at https://amp-polish.firebaseapp.com/manual/amp-inline-gallery/captions.html

  • Make lightboxing of slides work correctly
  • Make the "See more" button work correctly, replace text with an icon
  • Allow customization of the "See more" icon / message
  • Change lightbox, amp-truncate-text to display the non-truncated content when going to lightbox mode

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sepand Parhami seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants