Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for amp-fit-text #26142

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Add e2e tests for amp-fit-text #26142

merged 2 commits into from
Jan 8, 2020

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Dec 23, 2019

for #24038

@lannka lannka requested a review from powerivq December 23, 2019 22:41
@amp-owners-bot amp-owners-bot bot requested a review from nainar December 23, 2019 22:41
@lannka
Copy link
Contributor Author

lannka commented Dec 23, 2019

This PR is also an example of moving test/manual/*.html to test/e2e/fixture/*.html. We should prefer automated e2e test examples over manual test examples.

@ampproject/wg-ui-and-a11y @ampproject/wg-runtime

@lannka lannka merged commit 1afef3a into ampproject:master Jan 8, 2020
@lannka lannka deleted the amp-fit-text-e2e-test branch January 8, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@powerivq powerivq powerivq approved these changes

@nainar nainar Awaiting requested review from nainar

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lannka @jridgewell @powerivq @googlebot @ampprojectbot