Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰amp-form: Listen to FORM_VALUE_CHANGE to check validity on nested input fields. #26195

Merged
merged 5 commits into from
Jan 8, 2020
Merged

馃悰amp-form: Listen to FORM_VALUE_CHANGE to check validity on nested input fields. #26195

merged 5 commits into from
Jan 8, 2020

Conversation

caroqliu
Copy link
Contributor

@caroqliu caroqliu commented Jan 2, 2020 •
edited

Fixes #26137

  • Adds a reproducible sample that is fixed by this change
  • Adds an event listener for FORM_VALUE_CHANGE event that behaves the same as if a nested form element received an input event.

@samouri
Copy link
Member

samouri commented Jan 6, 2020 •
edited

Thanks for the test! LGTM

@caroqliu caroqliu merged commit 578a284 into ampproject:master Jan 8, 2020
@caroqliu caroqliu deleted the input-bind branch January 8, 2020 15:33
@caroqliu caroqliu restored the input-bind branch March 20, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri left review comments

@alanorozco alanorozco alanorozco approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-bind: Changing form inputs doesn't update validation state
5 participants
@caroqliu @samouri @alanorozco @googlebot @ampprojectbot