馃寜New "mobile" view for ads in fullbleed story #26243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
reviewed
Jan 9, 2020
| @@ -127,6 +139,9 @@ export class StoryAdPage { | |||
|
|
|||
| /** @private {boolean} */ | |||
| this.viewed_ = false; | |||
|
|
|||
| /** @private @const {!../../amp-story/0.1/amp-story-store-service.AmpStoryStoreService|!../../amp-story/1.0/amp-story-store-service.AmpStoryStoreService} */ | |||
There was a problem hiding this comment.
Is it desirable to have inter-version dependency?
There was a problem hiding this comment.
Good point! We should clean it but that'd be on the AMP Story WG to do it when we delete all the 0.1 code
gmajoulet
approved these changes
Jan 9, 2020
| @@ -48,6 +53,9 @@ const TIMEOUT_LIMIT = 10000; // 10 seconds | |||
| /** @const {string} */ | |||
| const GLASS_PANE_CLASS = 'i-amphtml-glass-pane'; | |||
|
|
|||
| /** @const {string} */ | |||
| const DESKTOP_FULLBLEED_CLASS = 'i-amphtml-story-desktop-fullbleed'; | |||
There was a problem hiding this comment.
Should we add another prefix to make it different from the class the AMP Story runtime uses? I'm afraid of CSS properties collisions eventually
|
|
||
| if (uiState === UIType.DESKTOP_FULLBLEED) { | ||
| this.adChoicesIcon_.classList.add(DESKTOP_FULLBLEED_CLASS); | ||
| } |
There was a problem hiding this comment.
If you feel like factorizing this in a single line (it's a bit less clear tho, so up to you)
this.adChoicesIcon_.classList.toggle(
DESKTOP_FULLBLEED_CLASS, uiState === UIType.DESKTOP_FULLBLEED);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story ads so far have not been responsive. Introduces a new view for fullbleed stories on desktop where we render the ad in a mobile like size.