馃悰Expander: better support of backticks #26264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@micajuine-ho can you take a look. Thank you |
micajuine-ho
approved these changes
Jan 9, 2020
|
@micajuine-ho I saw you recently added ownership of url-replacements. Do you think we should add expander to wg-analytics as well? |
calebcordry
commented
Jan 21, 2020
jridgewell
approved these changes
Jan 21, 2020
src/service/url-expander/expander.js
Outdated
| builder = ''; | ||
| // Collect any chars that may exist before backticks, eg FOO(a`b`) | ||
| if (builder.trim().length) { | ||
| results.push(builder.trim()); |
There was a problem hiding this comment.
Nit: Store the trimmed value, don't re-trim.
src/service/url-expander/expander.js
Outdated
| ); | ||
| builder = ''; | ||
| // Collect any chars that may exist before backticks, eg FOO(a`b`) | ||
| if (builder.trim().length) { |
There was a problem hiding this comment.
Nit: a length check is unnecessary, compare to an empty string or just let if (str) push(str);
src/service/url-expander/expander.js
Outdated
| // create a new array for the next argument, and reset our string | ||
| // builder. | ||
| // We push any string built so far, create a new array for the next | ||
| // argument, and reset our string builder. | ||
| if (builder.length) { |
There was a problem hiding this comment.
Shouldn't you be checking trimmed length?
There was a problem hiding this comment.
yes, good catch. Done.
src/service/url-expander/expander.js
Outdated
| if (nextArg) { | ||
| results.push(nextArg); | ||
| if (builder.trim().length) { | ||
| results.push(builder.trim()); |
|
Good to know about the trimming, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the parser ignoring feature only worked when an argument was completely wrapped in backticks eg
FOO(abc, ` - `)This allows backticks to be used anywhere inside of a macro to give raw input.
Follow up to #26247.