Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Implements unit test for amp-next-page v2 #26269

Merged
merged 2 commits into from
Jan 11, 2020
Merged

✅ Implements unit test for amp-next-page v2 #26269

merged 2 commits into from
Jan 11, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Jan 9, 2020 •
edited

Changes

  • Ports unit tests from amp-next-page v1 to v2 with a cleaner API
  • Adds new unit tests, with more to come in following PRs
  • Fixes bug in url rewriting

@wassgha wassgha requested a review from caroqliu January 9, 2020 01:07
caroqliu
caroqliu approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@caroqliu caroqliu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage looks good for the main component. :) Let's keep an eye on these helper files going forward.
Screen Shot 2020-01-10 at 5 43 18 PM

@wassgha wassgha merged commit 6163401 into ampproject:master Jan 11, 2020
@wassgha wassgha deleted the amp-next-page-v2-unit-tests branch January 11, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroqliu caroqliu caroqliu approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wassgha @caroqliu @googlebot @ampprojectbot