Remove z-index on flex ad slots by default. #26277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevitzky
requested review from
lannka and
jeffkaufman
and removed request for
jeffkaufman
jeffkaufman
approved these changes
Jan 9, 2020
lannka
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24653.
We currently set a fixed z-index on flex ad slots upon expansion which is causing ads to hover over publisher content (usually navigation components which also use a z-index, but often a lower value), with no obvious added benefit. After this PR is merged, we will default to not setting a z-index for flex ad slots, but will maintain a temporary holdback experiment to ensure no other breakages occur and to allow for the easy reversal of this change.
This also removes an old holdback experiment for enabling flex ad slots, which is no longer of use.