-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace canonicalUrl with ampdocUrl in Nielsen analytics #26278
Conversation
@alanorozco Could you please restart the Travis job? Thanks! |
@uniquelygeneric Restarted shards. Current reviewer @calebcordry also has restart powers FYI |
@uniquelygeneric the test failures are real, can you also update amphtml/extensions/amp-analytics/0.1/test/vendor-requests.json Lines 283 to 286 in b338300
This should fix the broken test. Thanks! |
@calebcordry whoops, forgot to update there, too. Thanks! Are we good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the continued maintenance of this impl!
Updated Nielsen analytics to utilize ampdocUrl in query param.