🔥🐛[yahoonativeads-amp] code cleanup and bug fix #26325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
approved these changes
Jan 13, 2020
|
@dysfunc Could you rebase on the latest master. The failure seems irrelevant. |
|
@powerivq updated |
|
Master is now unbroken. Can you rebase it again? @dysfunc |
danielrozenberg
approved these changes
Jan 15, 2020
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Jan 20, 2020
* master: [yahoonativeads-amp] code cleanup and bug fix (ampproject#26325) rephrased reasoning for text node (ampproject#26393) Render video alt and title attributes in vertical rendering mdoe. (ampproject#26370) Revert "Update I2I & I2S to reflect new Open Source process (ampproject#25530)" (ampproject#26392) Skip amp story affiliate link test (ampproject#26386) Update I2I & I2S to reflect new Open Source process (ampproject#25530) ✨ Add support for `"intrisic"` layout for `<amp-script>` (ampproject#26369) 📖 Rename Dev Channel to Experimental Channel in docs and comments (ampproject#26255) ✨Add support for AMP Story Quiz Reaction API calls (ampproject#26242) clarified text node behavior (ampproject#26376) # Conflicts: # extensions/amp-script/amp-script.md # extensions/amp-timeago/amp-timeago.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs some code cleanup by removing events hooks and resolves a minor bug.
onViewChangehook