🏗 🐛 Enable accessControls checks for JS code (and fix errors)

[rsimha]

The accessControls closure compiler visibility check rule is currently ignored during gulp check-types. Turning on the rule results in about 350+ annotation errors.

This PR enables the rule and fixes all incorrect annotation errors. It took only ~25 annotation changes to fix all 350+ errors.

Reference: https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#visibility-checks

Fixes #26307

[amp-owners-bot]

Hey @newmuis, these files were changed:

• extensions/amp-story/0.1/amp-story-share.js
• extensions/amp-story/0.1/amp-story-store-service.js
• extensions/amp-story/0.1/embed-mode.js
• extensions/amp-story/1.0/amp-story-draggable-drawer.js
• extensions/amp-story/1.0/amp-story-embedded-component.js
• extensions/amp-story/1.0/amp-story-share.js
• extensions/amp-story/1.0/amp-story-store-service.js
• extensions/amp-story/1.0/embed-mode.js
• extensions/amp-story/1.0/story-analytics.js

[erwinmombay]

@rsimha is protected the right visibility? it says that @protected should only be visible in subclasses or w/in the same file correct? most of these seem to be functions exported and used in a different module

[rsimha]

@rsimha is protected the right visibility? it says that @protected should only be visible in subclasses or w/in the same file correct? most of these seem to be functions exported and used in a different module

I believe the second rule under @protected is at play here (static methods and instance methods of any subclass of the class on which the property is defined).

Since changing the annotations to @protected satisfies gulp check-types, I didn't think it was necessary to make the access @public.

[erwinmombay]

@rsimha hmm i guess this might be a problem with nomenclature for me. those exported functions aren't static methods/instance methods to me (implies attached to a class)

[dreamofabear]

Thanks for fixing this.

[gmajoulet]

Story OWNERS approval

[jridgewell]

I think every top level value that's marked @protected should be @public (or better yet, just delete the annotation) if @package does not work for it.

[rsimha]

I think every top level value that's marked @protected should be @public (or better yet, just delete the annotation) if @package does not work for it.

Done. There were a few places where @package worked. For the rest, I removed the @protected annotation.

[rsimha]

Pretty sure I've addressed all feedback. Can I get a final review?