Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Proxy files from nested folder #26359

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Jan 15, 2020

No description provided.

[
'/examples/(**/)?*.html',
'/test/manual/(**/)?*.html',
'/test/fixtures/e2e/*/*.html',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if we want to proxy files from e2e's nested folder : )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done : ) now we also support files directly under e2e folder, but I believe that's fine.

@zhouyx zhouyx merged commit 535a1e7 into ampproject:master Jan 16, 2020
@zhouyx zhouyx deleted the nested-folder branch January 16, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants