馃殌 Disable FixedLayer when page is served canonically #26419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't see a way to move this to a draft. Apologies. |
dvoytenko
reviewed
Jan 21, 2020
kristoferbaxter
commented
Jan 21, 2020
| */ | ||
| setup() { | ||
| const viewer = Services.viewerForDoc(this.ampdoc); |
There was a problem hiding this comment.
Worth considering if this should return a boolean, especially since its only needed for tests.
jridgewell
reviewed
Jan 21, 2020
|
Ping @dvoytenko to review so we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AMP document is served canonically (like AMP.dev), the FixedLayer service is not needed.
This change disables the FixedLayer from performing its setup phase while we investigate a longer term fix. (#26397)