Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pauseCallback in amp-ima-video #26422

Merged
merged 1 commit into from Feb 11, 2020

Conversation

micajuine-ho
Copy link
Contributor

Closes #23365

Need to have pauseCallback() implemented, so that we can pause resources (amp-ima-video) when they are not visible anymore

pause() {
this.element.pauseCallback();
if (this.element.unlayoutOnPause()) {
this.unlayout();
}
}

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this! Might want to wait for @alanorozco expert approval :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp-ima-video in amp-carousel: video did not pause on swipe
5 participants