Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Skip broken amp-story-affiliate link test #26455

Merged
merged 1 commit into from
Jan 23, 2020
Merged

✅ Skip broken amp-story-affiliate link test #26455

merged 1 commit into from
Jan 23, 2020

Conversation

rcebulko
Copy link
Contributor

Seems to be broken (or at least very flaky):

This was skipped in #26386. That skip was reverted in #26395. I'm now un-reverting it.

@amp-owners-bot amp-owners-bot bot requested a review from newmuis January 23, 2020 16:20
@amp-owners-bot
Copy link

Hey @gmajoulet, these files were changed:

  • extensions/amp-story/1.0/test/integration/test-amp-story-affiliate-link.js

@gmajoulet
Copy link
Contributor

Thanks! Did you forget to commit the actual .skip statement?

@rcebulko
Copy link
Contributor Author

Thanks! Did you forget to commit the actual .skip statement?

Wow, I have no idea how I did that! Re-pushed the actual commit, thanks @gmajoulet

@rcebulko rcebulko merged commit 20398f9 into ampproject:master Jan 23, 2020
@rcebulko rcebulko deleted the skip branch January 23, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@erwinmombay erwinmombay Awaiting requested review from erwinmombay

@estherkim estherkim Awaiting requested review from estherkim

@newmuis newmuis Awaiting requested review from newmuis

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rcebulko @gmajoulet @googlebot