Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating path to Yahoo ad script #26460

Merged
merged 1 commit into from Feb 4, 2020
Merged

Updating path to Yahoo ad script #26460

merged 1 commit into from Feb 4, 2020

Conversation

src-code
Copy link
Contributor

Minor change to the path for the script loaded by yahoo amp-ad plugin.

@src-code
Copy link
Contributor Author

Looks like the test failures are Saucelabs timeouts in unrelated components.

@src-code
Copy link
Contributor Author

Hi @keithwrightbos, is there anything needed from my end to get this resolved?

@src-code src-code changed the title ♻️Updating path to Yahoo ad script Updating path to Yahoo ad script Jan 28, 2020
@src-code
Copy link
Contributor Author

src-code commented Feb 3, 2020

@lannka Any chance I can get your help with this one? (You were the original approver for #5727 which introduced this amp-ad embed type long ago.)

@calebcordry calebcordry merged commit 1c21a39 into ampproject:master Feb 4, 2020
@calebcordry
Copy link
Member

Thanks for maintaining this extension!

@src-code src-code deleted the yahoo-ad-js branch February 5, 2020 17:43
@src-code
Copy link
Contributor Author

src-code commented Feb 5, 2020

Thank you @calebcordry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

@keithwrightbos keithwrightbos Awaiting requested review from keithwrightbos

@lannka lannka Awaiting requested review from lannka

@powerivq powerivq Awaiting requested review from powerivq

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@src-code @calebcordry @googlebot @ampprojectbot