Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Change the opt-in cookie values to reflect upcoming CDN changes #26489

Merged

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Jan 24, 2020

Part of #25205
Tangentially related to #25560

@danielrozenberg
Copy link
Member Author

@ampproject/wg-infra one more pair of eyes before I merge this please :)

tools/experiments/experiments.js Outdated Show resolved Hide resolved
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. A few comments / questions.

tools/experiments/experiments.js Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Show resolved Hide resolved
tools/experiments/experiments.js Outdated Show resolved Hide resolved
tools/experiments/experiments.js Show resolved Hide resolved
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tools/experiments/experiments.js Outdated Show resolved Hide resolved
Co-Authored-By: Ryan Cebulko <ryan@cebulko.com>
@ampproject ampproject deleted a comment from googlebot Jan 28, 2020
@ampproject ampproject deleted a comment from googlebot Jan 28, 2020
@danielrozenberg danielrozenberg merged commit 2f0c12d into ampproject:master Jan 28, 2020
@danielrozenberg danielrozenberg deleted the change-cookie-value branch January 28, 2020 01:30
westonruter added a commit to westonruter/amphtml that referenced this pull request Jan 28, 2020
…frame-pymjs-support

* 'master' of github.com:ampproject/amphtml: (436 commits)
  🐛Add computed styles to fake win (ampproject#26514)
  📦 Update dependency eslint-config-prettier to v6.10.0 (ampproject#26518)
  🐛 Rewrite relative urls in the bookend (ampproject#26490)
  ✨ [amp-list] Introduce "amp-state:" as a usable protocol for the src attribute. (ampproject#26284)
  Add terminal newline to files.txt (ampproject#26513)
  📦 Update dependency chromedriver to v79.0.2 (ampproject#26515)
  ♻️ Change the opt-in cookie values to reflect upcoming CDN changes (ampproject#26489)
  ♻️<amp-next-page> v2 minor renaming and fixes (ampproject#26468)
  fix link (ampproject#26508)
  amp-list: fix broken test re. missing layout (ampproject#26509)
  performance: emit timeOrigin w/ polyfill (ampproject#26485)
  Position n+1 story desktop page before positioning attributes are set. (ampproject#26488)
  ✨amp-nested-menu: allow svg into (ampproject#26502)
  Log user warning when missing URL arg for shadow doc (ampproject#26290)
  📦 Update dependency puppeteer to v2.1.0 (ampproject#26501)
  Ensure that fluid slots hidden by media queries do not issue ad requests. (ampproject#26352)
  📦 Update dependency mocha to v7.0.1 (ampproject#26495)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants