Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Implement amp-ad-exit indirect targets #26517

Merged
merged 14 commits into from Feb 8, 2020
Merged

Conversation

jyn15
Copy link
Contributor

@jyn15 jyn15 commented Jan 28, 2020

Implement option 2 of #26241

/cc @clawr

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jyn15 jyn15 removed the request for review from jeffkaufman January 28, 2020 01:32
@lannka
Copy link
Contributor

lannka commented Jan 30, 2020

could you also add an e2e test for this?

/test-e2e/test-amp-ad-exit.js

@jyn15
Copy link
Contributor Author

jyn15 commented Jan 31, 2020

Added e2e tests. I tried to run e2e tests locally
gulp e2e --files=extensions/amp-ad-exit/0.1/test-e2e/test-amp-ad-exit.js --nobuild
it seems the tests are already failing on master branch for these environments:
AmpdocEnvironment.A4A_INABOX_FRIENDLY, AmpdocEnvironment.A4A_INABOX_SAFEFRAME

@lannka lannka requested review from powerivq and removed request for calebcordry January 31, 2020 17:35
@lannka
Copy link
Contributor

lannka commented Jan 31, 2020

@powerivq to help with the e2e tests

@jyn15
Copy link
Contributor Author

jyn15 commented Feb 5, 2020

Updated implementation to reflect the changes in the proposal #26241 (comment)

@jyn15
Copy link
Contributor Author

jyn15 commented Feb 6, 2020

Friendly ping :)

…d default value is not provided and the case in which the pointed-to target is not found
@jyn15 jyn15 requested a review from powerivq February 7, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants