Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Install built-in wait function for e2e request assertions #26523

Merged
merged 6 commits into from Jan 29, 2020
Merged

馃彈 Install built-in wait function for e2e request assertions #26523

merged 6 commits into from Jan 29, 2020

Conversation

estherkim
Copy link
Collaborator

@estherkim estherkim commented Jan 28, 2020 •
edited

Fixes e2e tests where request assertions i.e. to.have.been.sent flake but an error isn't caught.

Fixed by wrapping request assertions in a ControllerPromise, which describes.endtoend handles.

Closes #22270

@estherkim estherkim requested a review from rsimha January 28, 2020 20:59
micajuine-ho
micajuine-ho approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@micajuine-ho micajuine-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Esther!

@estherkim estherkim merged commit 1704f48 into ampproject:master Jan 29, 2020
@estherkim estherkim deleted the overwrite-expect branch January 29, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

@micajuine-ho micajuine-ho micajuine-ho approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow E2E tests to check network requests
5 participants
@estherkim @rsimha @micajuine-ho @googlebot @ampprojectbot