Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visual diff test for amp-consent #26532

Merged
merged 1 commit into from Feb 6, 2020

Conversation

micajuine-ho
Copy link
Contributor

Closes #25105

Visual diff test are currently testing for:

  • click accept -> all images show
  • click reject -> only _till_responded shows
  • click accept -> decision persists after page load

e2e tests cover all these legacy cases (#26013)

@micajuine-ho micajuine-ho changed the title Removed visual diff test for amp-consent Remove visual diff test for amp-consent Jan 28, 2020
Copy link
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if GH failed to show the change, but please also delete the visual-tests/amp-consent folder. Thanks for the e2e tests!

@micajuine-ho
Copy link
Contributor Author

Not sure if GH failed to show the change, but please also delete the visual-tests/amp-consent folder. Thanks for the e2e tests!

Should be removed. I don't think GH shows it though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky visual diff test for amp-consent
4 participants