Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validator-amp-mega-menu.protoascii #26598

Merged
merged 1 commit into from Feb 4, 2020

Conversation

ilknureren
Copy link
Contributor

@ilknureren ilknureren commented Feb 3, 2020

Currently, the documentation only provides one example of "Disallowed tag ancestor" error:

Currently, the only example is a template tag, which may not be nested under another template tag.

However, it seems that the svg tag cannot be nested under amp-mega-menu either.
Could it be added?

If not, we should document that "The tag 'svg' may not appear as a descendant of tag 'amp-mega-menu'."

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 3, 2020

Hey @ampproject/wg-caching, these files were changed:

  • extensions/amp-mega-menu/validator-amp-mega-menu.protoascii

@wassgha
Copy link
Contributor

wassgha commented Feb 3, 2020

We added this for amp-nested-menu through #26463 so it makes sense to do it for amp-mega-menu :)

@ilknureren
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Feb 3, 2020
Copy link
Member

@twifkak twifkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Validator protoascii usage looks good, but I'll leave it to @wassgha or another mega-menu OWNER to approve.

Copy link
Contributor

@wassgha wassgha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wassgha wassgha merged commit 9bc8756 into ampproject:master Feb 4, 2020
twifkak added a commit to twifkak/amphtml that referenced this pull request Feb 4, 2020
@twifkak twifkak mentioned this pull request Feb 4, 2020
twifkak added a commit that referenced this pull request Feb 5, 2020
* cl/291956471 Revision bump for #26502

* cl/293201160 Revision bump for #26598

Co-authored-by: Greg Grothaus <ggrothau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants