New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validator-amp-mega-menu.protoascii #26598
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hey @ampproject/wg-caching, these files were changed:
|
We added this for |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! Validator protoascii usage looks good, but I'll leave it to @wassgha or another mega-menu OWNER to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, the documentation only provides one example of "Disallowed tag ancestor" error:
Currently, the only example is a template tag, which may not be nested under another template tag.
However, it seems that the
svg
tag cannot be nested underamp-mega-menu
either.Could it be added?
If not, we should document that "The tag 'svg' may not appear as a descendant of tag 'amp-mega-menu'."