Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sharing layout when the label is two lines long. #26605

Merged
merged 1 commit into from Feb 4, 2020

Conversation

gmajoulet
Copy link
Contributor

Fixing the sharing layout to display labels that are up to 2 lines on mobile, desktop, and within the bookend.

Fixes #26602

Copy link
Contributor

@newmuis newmuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't just be a pure flex thing without negative margins? That way it doesn't matter how many lines it is

@gmajoulet
Copy link
Contributor Author

This can't just be a pure flex thing without negative margins? That way it doesn't matter how many lines it is

That'd be much better, but the code is spread out across many files: amp-social-share.css, amp-story-share.css, amp-story-share-menu.css, amp-story-bookend.css. Refactoring it is completely doable but not straightforward :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop sharing layout breaks for some languages
5 participants