🐛 amp-subscriptions: Fixes click event delegation for iOS 12 and lower #26658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of click event
jpettitt
approved these changes
Feb 7, 2020
ChrisAntaki
changed the title
dparikh
approved these changes
Feb 7, 2020
rcebulko
pushed a commit
to rcebulko/amphtml
that referenced
this pull request
Feb 7, 2020
ampproject#26658) * Listens on both the rootNode and its body if present, stops propagation of click event * Correctly listens to body additionally, adds a test
rcebulko
pushed a commit
to rcebulko/amphtml
that referenced
this pull request
Feb 7, 2020
ampproject#26658) * Listens on both the rootNode and its body if present, stops propagation of click event * Correctly listens to body additionally, adds a test
rcebulko
pushed a commit
to rcebulko/amphtml
that referenced
this pull request
Feb 7, 2020
ampproject#26658) * Listens on both the rootNode and its body if present, stops propagation of click event * Correctly listens to body additionally, adds a test
rcebulko
pushed a commit
that referenced
this pull request
Feb 7, 2020
#26658) * Listens on both the rootNode and its body if present, stops propagation of click event * Correctly listens to body additionally, adds a test
erwinmombay
pushed a commit
that referenced
this pull request
Feb 18, 2020
#26658) * Listens on both the rootNode and its body if present, stops propagation of click event * Correctly listens to body additionally, adds a test
rcebulko
pushed a commit
that referenced
this pull request
Feb 19, 2020
#26658) * Listens on both the rootNode and its body if present, stops propagation of click event * Correctly listens to body additionally, adds a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix an issue with click handling in iOS 12 and lower (#25754), listen to both the root node and, if it's defined, its body property as well.