🐛 Subscriptions: Stops stopping propagation of click events #26702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works with Chrome's mobile emulation. Now I'm testing it with real mobile devices |
jpettitt
approved these changes
Feb 11, 2020
|
LGTM but please have @dvoytenko take a look as well to confirm the approach is ok within AMP as a whole |
dvoytenko
approved these changes
Feb 11, 2020
extensions/amp-subscriptions/0.1/local-subscription-platform-base.js
Outdated
Show resolved
Hide resolved
erwinmombay
pushed a commit
that referenced
this pull request
Feb 11, 2020
* Stops stopping propagation of click events * Add test * Creates const and uses array accessor for surrogate property on click events
erwinmombay
pushed a commit
that referenced
this pull request
Feb 11, 2020
* Stops stopping propagation of click events * Add test * Creates const and uses array accessor for surrogate property on click events
erwinmombay
pushed a commit
that referenced
this pull request
Feb 14, 2020
* Stops stopping propagation of click events * Add test * Creates const and uses array accessor for surrogate property on click events
erwinmombay
pushed a commit
that referenced
this pull request
Feb 18, 2020
* Stops stopping propagation of click events * Add test * Creates const and uses array accessor for surrogate property on click events
rcebulko
pushed a commit
that referenced
this pull request
Feb 19, 2020
* Stops stopping propagation of click events * Add test * Creates const and uses array accessor for surrogate property on click events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopping the propagation of
clickevents broke theamp-bindextension. This PR uses a new method to ensureclickevents are only handled once by theamp-subscriptionsextension. Basically, an additional property, specific toamp-subscriptions, is added to the event when it is first handled, and the handler bails if it is present on a subsequent call.I plan to test this PR across a variety of devices/browsers using the PR deploy tool described here:
https://github.com/ampproject/amp-github-apps/blob/master/pr-deploy/README.md