馃殌 Remove older performance info #26711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkimball
approved these changes
Feb 10, 2020
|
Code LGTM. I don't have the context on why we had these special cases and why its okay to remove now, any chance you can either explain or point me to things to read? |
|
These branches handled older implementations in Chromium of the API solidified in Chromium 77. Now that it's stable, and has been released for awhile we can stop collecting data on the older APIs. |
|
Do we have stats on the % of users that are still on versions before 77, or is there some kind of heuristic/rule-of-thumb that is safe to use? |
samouri
approved these changes
Feb 11, 2020
|
https://amp.dev/support/faq/supported-browsers/ Chromium 76 just left the window for supported browsers, we support Chromium 78 and beyond as of today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several codepaths in
performance-implthat supported behaviour for capturing data from Chromium user-agents older than version 77 (including for just 76).Removing the older methods makes the implementation smaller, slightly more efficient, and easier to understand.