Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trying to update Sauce timeouts #26737

Merged
merged 1 commit into from
Feb 13, 2020
Merged

trying to update Sauce timeouts #26737

merged 1 commit into from
Feb 13, 2020

Conversation

joshmgrant
Copy link
Contributor

No description provided.

rcebulko
rcebulko reviewed Feb 13, 2020
View reviewed changes
Copy link
Contributor

@rcebulko rcebulko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, going to pull in @rsimha in case he knows of any possible downstream effects or other elements of our test system that could be impacted or might need timeouts adjusted. Thanks for looking at this!

@joshmgrant joshmgrant marked this pull request as ready for review February 13, 2020 16:15
rsimha
rsimha approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @joshmgrant. I just read https://wiki.saucelabs.com/display/DOCS/Test+Configuration+Options#TestConfigurationOptions-Timeouts and these changes seem worth trying.

@rsimha rsimha merged commit bf584f6 into ampproject:master Feb 13, 2020
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Feb 17, 2020
@robinvanopstal
Merge branch 'master' into component-intro-tables
9a3ae47 
* master: (181 commits)
  🏗 Ensure valid flag usage for `gulp` tasks (ampproject#26814)
  build-system: Fix autocomplete error response (ampproject#26824)
  application/json is ab allowed type for <script> (ampproject#26815)
  🚮 Removing amp-consent-v2 experiment logic (ampproject#26162)
  Fix more arrow functions that are passed in as "constructors" (ampproject#26795)
  Variable substitution tester  (ampproject#26695)
  Turn on restrict fullscreen canary (ampproject#26766)
  Mock variableService getMacros  (ampproject#26300)
  Sync from Google (ampproject#26805)
  Sync from Google (ampproject#26803)
  Move video_state macro (ampproject#26212)
  🚀 Move ads variables to amp-analytics (ampproject#25113)
  Sync from Google (ampproject#26800)
  Sync from Google (ampproject#26798)
  Sync from Google (ampproject#26792)
  Another set of example.com change (ampproject#26753)
  Add PWA multidoc loader to examples (ampproject#26680)
  🐛Check for window null before creating tracking pixel (ampproject#26749)
  trying to update Sauce timeouts (ampproject#26737)
  🐛Fixes swipe to dismiss badly ordered swipes on `amp-lightbox-gallery` (ampproject#26788)
  ...

# Conflicts:
#	extensions/amp-accordion/amp-accordion.md
#	extensions/amp-bind/amp-bind.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko left review comments

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joshmgrant @rcebulko @rsimha @googlebot @ampprojectbot