Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[amp-story-player] Adds navigation logic #26751

Merged
merged 8 commits into from
Feb 19, 2020
Merged

✨[amp-story-player] Adds navigation logic #26751

merged 8 commits into from
Feb 19, 2020

Conversation

Enriqe
Copy link
Contributor

@Enriqe Enriqe commented Feb 12, 2020

Closes #26696

Tracker #26308

@Enriqe Enriqe self-assigned this Feb 12, 2020
@Enriqe Enriqe marked this pull request as ready for review February 12, 2020 01:33
gmajoulet
gmajoulet reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some basic tests? :))

src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
@Enriqe
Copy link
Contributor Author

Enriqe commented Feb 13, 2020

PTAL

gmajoulet
gmajoulet reviewed Feb 14, 2020
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nits, it's looking good, LGTM otherwise :))

src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
test/unit/test-amp-story-player.js Show resolved Hide resolved
test/unit/test-amp-story-player.js Outdated Show resolved Hide resolved
@Enriqe
Copy link
Contributor Author

Enriqe commented Feb 18, 2020 •
edited

Adding @samouri for owners approval (as suggested by the bot).

@Enriqe Enriqe requested a review from samouri February 18, 2020 19:06
@Enriqe
Copy link
Contributor Author

Enriqe commented Feb 18, 2020

PTAL @gmajoulet

gmajoulet
gmajoulet approved these changes Feb 19, 2020
View reviewed changes
src/amp-story-player-iframe-pool.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
src/amp-story-player.js Outdated Show resolved Hide resolved
Enriqe
Enriqe commented Feb 19, 2020
View reviewed changes
Copy link
Contributor Author

@Enriqe Enriqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

friendly ping @samouri for owners file

src/amp-story-player-iframe-pool.js Outdated Show resolved Hide resolved
samouri
samouri approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving just the src/owners file.

@Enriqe
Copy link
Contributor Author

Enriqe commented Feb 19, 2020

Thanks!

@Enriqe Enriqe merged commit 5bcb4de into ampproject:master Feb 19, 2020
@newmuis newmuis mentioned this pull request Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@samouri samouri samouri approved these changes

@newmuis newmuis Awaiting requested review from newmuis

Assignees

@Enriqe Enriqe

Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[amp-story-player] Support pre-rendering of next story
5 participants
@Enriqe @gmajoulet @samouri @googlebot @ampprojectbot