Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️Move new methods in resources service to package visibility #26752

Merged
merged 1 commit into from
Feb 13, 2020
Merged

♻️Move new methods in resources service to package visibility #26752

merged 1 commit into from
Feb 13, 2020

Conversation

powerivq
Copy link
Contributor

These new methods are only supposed to be used in the framework (vs extension), so it makes sense to make them visible only in package.

@powerivq powerivq requested review from dreamofabear and removed request for jridgewell February 12, 2020 01:26
@powerivq
Copy link
Contributor Author

powerivq commented Feb 12, 2020 •
edited

Might help the js minimizer know these method names can be minified, but not sure.

UPDATE: It doesn't.

kristoferbaxter
kristoferbaxter approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the single-pass output too. We have more aggressive minification enabled there.

dreamofabear
dreamofabear approved these changes Feb 13, 2020
View reviewed changes
Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powerivq powerivq merged commit 5db0dcd into ampproject:master Feb 13, 2020
@powerivq powerivq deleted the presubmit-mutator branch February 13, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@powerivq @kristoferbaxter @dreamofabear @googlebot @ampprojectbot