Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈馃悰 Wait for Percy agent to start before performing visual diff tests #26769

Merged
merged 2 commits into from
Feb 12, 2020
Merged

馃彈馃悰 Wait for Percy agent to start before performing visual diff tests #26769

merged 2 commits into from
Feb 12, 2020

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Feb 12, 2020 •
edited

Race conditions are fun

/cc @westonruter whose PR stumbled on this bug

rsimha
rsimha reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after two comments are addressed.

build-system/tasks/visual-diff/index.js Outdated Show resolved Hide resolved
build-system/tasks/visual-diff/index.js Show resolved Hide resolved
@danielrozenberg danielrozenberg merged commit 39283a9 into ampproject:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielrozenberg @rsimha @googlebot @ampprojectbot