Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validator version & fix tests #26775

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Update validator version & fix tests #26775

merged 1 commit into from
Feb 13, 2020

Conversation

sebastianbenz
Copy link
Contributor

We should update the AMP validator dependency to 1.30.0 as well.

@amp-owners-bot
Copy link

Hey @ampproject/wg-caching, these files were changed:

  • validator/gulpjs/package.json
  • validator/gulpjs/test/validate.js

@sebastianbenz sebastianbenz merged commit c960df4 into ampproject:master Feb 13, 2020
@sebastianbenz sebastianbenz deleted the gulp-validator-update branch February 13, 2020 07:47
@sebastianbenz
Copy link
Contributor Author

@honeybadgerdontcare can you publish the module to NPM?

@honeybadgerdontcare
Copy link
Contributor

@sebastianbenz done

@honeybadgerdontcare honeybadgerdontcare mentioned this pull request Feb 13, 2020
Merged
@sebastianbenz
Copy link
Contributor Author

sebastianbenz commented Feb 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sebastianbenz @honeybadgerdontcare @googlebot @ampprojectbot