Do not allow arrow functions as the "factory" function for registerServiceDorDoc #26776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jridgewell, these files were changed:
|
rsimha
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
Hang on... I'm summoning my inner @jridgewell as I read this...
Okay, LGTM.
|
i'm going to file a bug against closure compiler as well, as Arrow Functions should not be allowed to be passed into a parameter that is |
kristoferbaxter
approved these changes
Feb 12, 2020
erwinmombay
added a commit
that referenced
this pull request
Feb 13, 2020
…rviceDorDoc (#26776) * don't allow registration of arrow function as factory * apply lint fixes * Do not allow arrow functions as the "factory" function
erwinmombay
added a commit
that referenced
this pull request
Feb 18, 2020
…rviceDorDoc (#26776) * don't allow registration of arrow function as factory * apply lint fixes * Do not allow arrow functions as the "factory" function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the module build this errors out because arrow functions are not
newable