Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync from Google #26856

Merged
merged 40 commits into from
Feb 19, 2020
Merged

Sync from Google #26856

merged 40 commits into from
Feb 19, 2020

Conversation

honeybadgerdontcare
Copy link
Contributor

This is an automatically generated pull request.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 19, 2020 •
edited

Hey @ampproject/wg-caching, these files were changed:

  • validator/htmlparser/BUILD
  • validator/htmlparser/README.md
  • validator/htmlparser/WORKSPACE
  • validator/htmlparser/bin/jsongrammargen.cc
  • validator/htmlparser/data/jsongrammar.txt
  • validator/htmlparser/fileutil.cc
  • validator/htmlparser/fileutil.h
  • validator/htmlparser/fileutil_test.cc
  • validator/htmlparser/grammar/tablebuilder.cc
  • validator/htmlparser/grammar/tablebuilder.h
  • validator/htmlparser/json/jsondataset_test.cc
  • validator/htmlparser/json/parser.cc
  • validator/htmlparser/json/parser.h
  • validator/htmlparser/json/parser_test.cc
  • validator/htmlparser/json/states.h
  • validator/htmlparser/json/testdata/1.json
  • validator/htmlparser/json/testdata/10.json
  • validator/htmlparser/json/testdata/2.json
  • validator/htmlparser/json/testdata/3.json
  • validator/htmlparser/json/testdata/4.json
  • validator/htmlparser/json/testdata/5.json
  • validator/htmlparser/json/testdata/6.json
  • validator/htmlparser/json/testdata/7.json
  • validator/htmlparser/json/testdata/8.json
  • validator/htmlparser/json/testdata/9.json
  • validator/htmlparser/json/testdata/README
  • validator/htmlparser/logging.h
  • validator/htmlparser/node.cc
  • validator/htmlparser/parser.cc
  • validator/htmlparser/parser_test.cc
  • validator/htmlparser/renderer.cc
  • validator/htmlparser/strings.cc
  • validator/htmlparser/strings.h
  • validator/htmlparser/strings_test.cc
  • validator/htmlparser/whitespacetable.h

amaltas and others added 23 commits February 18, 2020 21:50
@amaltas @honeybadgerdontcare
1) Introduce exclude char '^'
67212bb 
2) Implement range syntax.
3) Introduce '\u' identifier for non-ascii character match.

PiperOrigin-RevId: 293155674
@amaltas @honeybadgerdontcare
Add IsWhitespaceChar function that determines if a character at a given
2092e50 
position is a whitespace char including any unicode whitespace.

PiperOrigin-RevId: 293718940
@amaltas @honeybadgerdontcare
Adds Strings::SplitStrAtUtf8Whitespace string util method.
05f8023 
PiperOrigin-RevId: 293834550
@amaltas @honeybadgerdontcare
Fix build errors.
fe20328 
PiperOrigin-RevId: 293885884
@amaltas @honeybadgerdontcare
Fix strings::Escape
46f533d 
PiperOrigin-RevId: 293897944
@amaltas @honeybadgerdontcare
JSON grammer do not allow trailing commas [1,] {"a":"b",}.
96707bb 
Fixes this. Previously trailing commas were considered OK.

START_PUBLIC
Fix trailing comma in json parser.

PiperOrigin-RevId: 294938254
@honeybadgerdontcare
Internal refactoring.
d53eab5 
PiperOrigin-RevId: 294983985
@honeybadgerdontcare
Prettify entities.json
27a2e04 
PiperOrigin-RevId: 295032659
@honeybadgerdontcare
Add missing licenses and other clean up.
5ad475a 
PiperOrigin-RevId: 295033719
@honeybadgerdontcare
Remove license comment from JSON file
56445e4 
PiperOrigin-RevId: 295072895
@amaltas @honeybadgerdontcare
Replace base/logging.h with htmlparser/logging.h
efc1331 
PiperOrigin-RevId: 295794452
@honeybadgerdontcare
Added bazel build files for htmlparser.
5ba27e4 
Updated README.md with details on building and testing.

PiperOrigin-RevId: 295803731
@honeybadgerdontcare
Minor bug fixes
2f50185 
PiperOrigin-RevId: 295828454
@amaltas @honeybadgerdontcare
Fix error: 'cerr' is not a member of 'std'
19fc273 
PiperOrigin-RevId: 295828491
@honeybadgerdontcare
Update json testdata.
83113f0 
PiperOrigin-RevId: 295828770
@honeybadgerdontcare
Update json testfiles.
5747de4 
PiperOrigin-RevId: 295829872
@honeybadgerdontcare
Update json testdata.
48b1577 
PiperOrigin-RevId: 295831774
@amaltas @honeybadgerdontcare
throw runtime error for unknown namespace.
8386dfd 
PiperOrigin-RevId: 295835358
@amaltas @honeybadgerdontcare
Fix fileutil issue.
c268d59 
PiperOrigin-RevId: 295835589
@amaltas @honeybadgerdontcare
Fix std::find errors.
6fb66be 
PiperOrigin-RevId: 295851119
@amaltas @honeybadgerdontcare
Fixes compiler warnings of wrong types.
44afd63 
PiperOrigin-RevId: 295852676
@honeybadgerdontcare
Prettify README.md
6aa7301 
PiperOrigin-RevId: 295889757
@honeybadgerdontcare
gulp prettify
fc57158 
PiperOrigin-RevId: 295890877
@honeybadgerdontcare honeybadgerdontcare merged commit a2a9c26 into master Feb 19, 2020
@rsimha rsimha deleted the piper_13 branch April 10, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaltas amaltas amaltas approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@honeybadgerdontcare @amaltas @googlebot @ampprojectbot