Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update broken CDN link in social-share example #2686

Merged
merged 1 commit into from Mar 24, 2016
Merged

update broken CDN link in social-share example #2686

merged 1 commit into from Mar 24, 2016

Conversation

mannynotfound
Copy link
Contributor

Recently used this code as a reference to building my own share tools and noticed the amp-social-share CDN is 404ing. This updates to the correct path.

Recently used this code as a reference to building my own share tools and noticed the amp-social-share CDN is 404ing. This updates to the correct path.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mannynotfound
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jridgewell
Copy link
Contributor

Test failure is unrelated, merging. Thanks!

@jridgewell jridgewell merged commit 8cce705 into ampproject:master Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants