Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Check for null on bad video message JSON parses #26947

Merged
merged 2 commits into from
Feb 25, 2020
Merged

馃悰 Check for null on bad video message JSON parses #26947

merged 2 commits into from
Feb 25, 2020

Conversation

alanorozco
Copy link
Member

tryParseJson was modified to return null, this updates checks for all video players.

Fixes #26895

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 24, 2020 •
edited

Hey @wassgha, these files were changed:

  • extensions/amp-3q-player/0.1/amp-3q-player.js
  • extensions/amp-3q-player/0.1/test/test-amp-3q-player.js
  • extensions/amp-delight-player/0.1/amp-delight-player.js
  • extensions/amp-minute-media-player/0.1/amp-minute-media-player.js
  • extensions/amp-nexxtv-player/0.1/amp-nexxtv-player.js
  • extensions/amp-powr-player/0.1/amp-powr-player.js
  • extensions/amp-redbull-player/0.1/amp-redbull-player.js
  • extensions/amp-wistia-player/0.1/amp-wistia-player.js

@alanorozco alanorozco changed the title Check for null on bad video message JSON parses 馃悰 Check for null on bad video message JSON parses Feb 24, 2020
@alanorozco alanorozco removed the request for review from ajwhatson February 24, 2020 21:29
@alanorozco alanorozco merged commit 978dcbb into ampproject:master Feb 25, 2020
@alanorozco alanorozco deleted the objparsejson branch February 25, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@zhouyx zhouyx zhouyx approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-delight-player: Error: Cannot read property 'type' of null
5 participants
@alanorozco @kristoferbaxter @zhouyx @googlebot @ampprojectbot