Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OWNER wg-ads to wg-ads-reviewers #27186

Merged
merged 4 commits into from Mar 10, 2020

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Mar 10, 2020

Creating a separate "GH team" for wg-ads PR reviews, that we can freely change according to members availability.

ads/OWNERS Outdated
@@ -5,7 +5,7 @@
rules: [
{
owners: [
{name: 'ampproject/wg-ads'},
{name: 'ampproject/wg-ads-reviewers'},
{name: 'jeffkaufman', requestReviews: false},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this, since Jeff will not be in the new group?

Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This should definitely improve the usefulness of Owners Bot's reviewer selections. I'll add that this means other members of the working group won't have the ability to provide owners approval even if they want to, but I'm guessing this is fine her.

@rcebulko
Copy link
Contributor

Updating @jeffkaufman : You won't be assigned any more PR reviews now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants