✨ New feature: Adding our platform MoEngage as an amp-analytics plugin.

[nawazMoEngage]

• I2I reference: I2I: adding amp-analytics for MoEngage #27221
• Implemented amp-analytics for the vendor MoEngage.
• Docs for the client to use this plugin: https://docs.moengage.com/docs/amp-event-analytics

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[micajuine-ho]

nit: 2020

[micajuine-ho]

Hi @nawazMoEngage, thanks for your integration. Just a few nits before we can merge. Thanks!

[micajuine-ho]

"addDevice": "https://websdk.moengage.com/v2/device/add?os=mweb&app_id=!appId&sdk_ver=0.0.0&app_ver=1&device_tz=_timezone_&os_platform=_user_agent_&unique_id=_client_id(moe_uuid)_&device_ts=_timestamp_&isAmp=true&a=%5Bobject%20Object%5D&meta=%5Bobject%20Object%5D&url=_ampdoc_url_"

"event": "https://websdk.moengage.com/v2/device/add?os=mweb&app_id=!appId&sdk_ver=0.0.0&app_ver=1&device_tz=_timezone_&os_platform=_user_agent_&unique_id=_client_id(moe_uuid)_&device_ts=_timestamp_&a=%5Bobject%20Object%5D&meta=%5Bobject%20Object%5D&url=_ampdoc_url_"

Please review these corrections to ensure they're formatted the way you want and let me know if you have any questions. Note: the extraUrlParams that are objects get resolved to [object Object] in these tests, but since you have useBody, they will not resolve this way when the requests are actually sent.

[nawazMoEngage]

@micajuine-ho why it is resolving to the url params? Since I am using useBody and xhrpost, extraUrlParams should go in the request body.
If that is not the case, then how can I have objects in extraUrlParams?

[micajuine-ho]

It will go in the request body in the actual request. What's happening here is that our testing framework doesn't account for this scenario right now, and so it always appends the extraUrlParams

[nawazMoEngage]

Thanks for clarifying. What will you suggest me to do now? we are not in the situation to have this API rewritten from the backend.

[micajuine-ho]

I can fix the testing setup to account for this situation correctly, and then we can retest to make sure that it aligns with your backend endpoints.

How does that sound?

[nawazMoEngage]

sounds great. Thanks a lot..
Hope it will not take much time. :)

[nawazMoEngage]

@micajuine-ho Hi Micajuine, any update on this?

[micajuine-ho]

Hi, no updates as of yet. We've had other items of high priority to attend to recently. I will try to carve some time out this week to finish this. Thanks for the reminder.

[nawazMoEngage]

@googlebot I signed it!

[nawazMoEngage]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[micajuine-ho]

Hi @nawazMoEngage thank you for your patience. I created a PR (#27792) that outlines possible solutions. I will update you as that PR progresses.

[micajuine-ho]

@nawazMoEngage I think you should just fix your requests right now to satisfy the current tests (there's a chance that we don't end up fixing the tests because other vendors are currently working around it as well). If we do end up changing the tests, I can update the requests.

You would need to change the requests in vendor-requests.json to this:

• https://websdk.moengage.com/v2/device/add?os=mweb&app_id=!appId&sdk_ver=0.0.0&app_ver=1&device_tz=_timezone_&os_platform=_user_agent_&unique_id=_client_id(moe_uuid)_&device_ts=_timestamp_&isAmp=true&a=%5Bobject%20Object%5D&meta=%5Bobject%20Object%5D&url=_ampdoc_url_
• https://websdk.moengage.com/v2/report/add?os=mweb&app_id=!appId&sdk_ver=0.0.0&app_ver=1&device_tz=_timezone_&os_platform=_user_agent_&unique_id=_client_id(moe_uuid)_&device_ts=_timestamp_&a=%5Bobject%20Object%5D&meta=%5Bobject%20Object%5D&url=_ampdoc_url_

[nawazMoEngage]

@nawazMoEngage I think you should just fix your requests right now to satisfy the current tests (there's a chance that we don't end up fixing the tests because other vendors are currently working around it as well). If we do end up changing the tests, I can update the requests.

You would need to change the requests in vendor-requests.json to this:

• https://websdk.moengage.com/v2/device/add?os=mweb&app_id=!appId&sdk_ver=0.0.0&app_ver=1&device_tz=_timezone_&os_platform=_user_agent_&unique_id=_client_id(moe_uuid)_&device_ts=_timestamp_&isAmp=true&a=%5Bobject%20Object%5D&meta=%5Bobject%20Object%5D&url=_ampdoc_url_
• https://websdk.moengage.com/v2/report/add?os=mweb&app_id=!appId&sdk_ver=0.0.0&app_ver=1&device_tz=_timezone_&os_platform=_user_agent_&unique_id=_client_id(moe_uuid)_&device_ts=_timestamp_&a=%5Bobject%20Object%5D&meta=%5Bobject%20Object%5D&url=_ampdoc_url_

OK done..

[zhouyx]

Can we please remove moengage.js from the code base. It's no longer required.