Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Always unlock pages that have unlocked config #27265

Merged
merged 1 commit into from Mar 17, 2020
Merged

馃悰 Always unlock pages that have unlocked config #27265

merged 1 commit into from Mar 17, 2020

Conversation

jpettitt
Copy link
Contributor

Fixes #27262

ChrisAntaki
ChrisAntaki approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@ChrisAntaki ChrisAntaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jpettitt jpettitt merged commit e0a7879 into ampproject:master Mar 17, 2020
@jpettitt jpettitt deleted the swg-free branch March 17, 2020 18:37
@ChrisAntaki ChrisAntaki mentioned this pull request Mar 19, 2020
Closed
twintwox pushed a commit to twintwox/amphtml that referenced this pull request Mar 24, 2020
@jpettitt @twintwox
Always unlock pages that have unlocked config (ampproject#27265)
fc275bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisAntaki ChrisAntaki ChrisAntaki approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-subscriptions behavior is undefined if isAccesibleForFree is true.
4 participants
@jpettitt @ChrisAntaki @googlebot @ampprojectbot