Initial smatr-ads-net #27382
Merged
Initial smatr-ads-net #27382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not the correct reviewer for Ads related code. @powerivq is more appropriate. Unassigning myself. |
|
@nainar adding you back since ads do not own the extensions/ folder, and we need your owner approval to create a new extension. |
|
@kristoferbaxter Yeah, I am. |
powerivq
requested changes
Mar 25, 2020
| let src; | ||
| return ( | ||
| !useRemoteHtml && | ||
| !!(src = element.getAttribute('src')) && |
There was a problem hiding this comment.
@powerivq I don 't quite understand
There was a problem hiding this comment.
Can this assignment be moved to below (line 32)? The logic here is a bit difficult to understand.
let src = element.getAttribute('src');
return (
!useRemoteHtml &&
!!src &&
....
powerivq
approved these changes
Mar 25, 2020
|
@powerivq – Looks like a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.