🚀Only resize viewport during constructor when embedded #27416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Mar 26, 2020
| @@ -155,7 +155,9 @@ export class ViewportImpl { | |||
| 'disableScroll', | |||
| this.disableScrollEventHandler_.bind(this) | |||
| ); | |||
| this.binding_.updatePaddingTop(this.paddingTop_); | |||
| if (this.viewer_.isEmbedded()) { | |||
dvoytenko
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing AMP content on origins or via signed-exchanges, the viewport sets a
padding-topand css variable forpadding-topto 0.This change can be expensive on complex and large DOM structures during boot. See attached image of a trace from a complex AMP Document on a Nokia 3.2.
This PR only sets the styles when an AMP document is embedded inside a viewer.