Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the advancementMode with the selectDocument messaging. #27444

Merged
merged 2 commits into from Mar 30, 2020
Merged

Expose the advancementMode with the selectDocument messaging. #27444

merged 2 commits into from Mar 30, 2020

Conversation

gmajoulet
Copy link
Contributor

@gmajoulet gmajoulet commented Mar 26, 2020 •
edited

Expose the advancementMode with the selectDocument messaging.

@gmajoulet gmajoulet changed the title Expose the advancementMode with the selectDocument API. Expose the advancementMode with the selectDocument messaging. Mar 26, 2020
@gmajoulet gmajoulet force-pushed the select_document_advancement_mode branch from e1735b4 to 69e9925 Compare March 26, 2020 22:31
newmuis
newmuis reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@newmuis newmuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for auto advance?

@gmajoulet
Copy link
Contributor Author

Of course, done.

@gmajoulet gmajoulet merged commit e7def6b into ampproject:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newmuis newmuis newmuis approved these changes

@Enriqe Enriqe Enriqe approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gmajoulet @newmuis @Enriqe @googlebot @ampprojectbot