馃枍 Hide pagination arrows in story embedmode=1 and embedmode=3 #27463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
reviewed
Mar 27, 2020
There was a problem hiding this comment.
I don't know if it's worth it, but we have comments in embed-mode.js that state what each embedMode does, might be worth updating those as well:
amphtml/extensions/amp-story/1.0/embed-mode.js
Lines 33 to 37 in 59d32d7
gmajoulet
reviewed
Mar 27, 2020
| @@ -565,6 +567,7 @@ export class AmpStoryStoreService { | |||
| [StateProperty.CAN_INSERT_AUTOMATIC_AD]: false, | |||
| [StateProperty.CAN_SHOW_BOOKEND]: false, | |||
| [StateProperty.CAN_SHOW_NAVIGATION_OVERLAY_HINT]: false, | |||
| [StateProperty.CAN_SHOW_PAGINATION_BUTTONS]: false, | |||
There was a problem hiding this comment.
Can you add a default that'd be true? (sorry, can't comment on the actual line where this would happen...) Otherwise the pagination buttons would never be visible
gmajoulet
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.