馃悰 Mark initMessagingChannel timeout as expected error #27514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #27247
That PR attempted to mark the timeout error as expected by checking that the error message raised by
timeoutPromise
was theopt_message
provided. What I missed at the time was thatgetChannelError
prepends text to the error message, so the equality check failed and didn't actually mark the error as expected.This PR updates the check to instead verify that the error reason matches the
opt_message
provided totimeoutPromise