Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Mark initMessagingChannel timeout as expected error #27514

Merged
merged 4 commits into from Apr 1, 2020

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Mar 31, 2020

This PR is a follow-up to #27247

That PR attempted to mark the timeout error as expected by checking that the error message raised by timeoutPromise was the opt_message provided. What I missed at the time was that getChannelError prepends text to the error message, so the equality check failed and didn't actually mark the error as expected.

This PR updates the check to instead verify that the error reason matches the opt_message provided to timeoutPromise

@rcebulko rcebulko merged commit b2f2198 into ampproject:master Apr 1, 2020
@rcebulko rcebulko deleted the init branch April 1, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants