🚀 Flatten Literals in TemplateLiterals #27516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristoferbaxter
changed the title
jridgewell
reviewed
Apr 2, 2020
erwinmombay
approved these changes
Apr 3, 2020
jridgewell
reviewed
Apr 3, 2020
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| let add = `/rtv/bar`; |
There was a problem hiding this comment.
Terser seems to accomplish all of these.
There was a problem hiding this comment.
Looking at the output of our build process, it is not for us. Would prefer to have less reliance on terser for these kinds of changes.
| name: 'flatten-stringish-literals', | ||
| visitor: { | ||
| BinaryExpression: { | ||
| exit(path) { |
There was a problem hiding this comment.
I think we can simplify this a lot using Babel's evaluator: https://astexplorer.net/#/gist/2f15d0fd95e70d31d1eb9314d68d5b94/b6b9de562a4f71911db7585d0564d74aff85bf41
There was a problem hiding this comment.
Absolutely. Good idea, will address in a followup.
ChrisAntaki
pushed a commit
to ChrisAntaki/amphtml
that referenced
this pull request
Apr 3, 2020
* Refactor to support more cases * Fix bug in function-declarations prohibiting other plugins from working * yarn lock was out of date somehow * Merge stringish literals * Add in output for tests * Remove console log debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary work.
This change will eventually be upstreamed into Closure Compiler, and can be removed after upgrading to a newer version.