Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰resolve build errors in testing due to new css.protoascii #27531

Merged
merged 2 commits into from Apr 4, 2020
Merged

馃悰resolve build errors in testing due to new css.protoascii #27531

merged 2 commits into from Apr 4, 2020

Conversation

GeorgeLuo
Copy link
Contributor

  • added a cat to roll in css.protoascii from validator/ level
  • removed a test, due to changes in style's blacklist (no more fail on !important attribute)

@amp-owners-bot amp-owners-bot bot requested a review from Gregable April 1, 2020 21:03
@amp-owners-bot
Copy link

amp-owners-bot bot commented Apr 1, 2020

Hey @ampproject/wg-caching, these files were changed:

validator/java/src/main/bin/fetchAMPResources.sh
validator/java/src/test/java/dev/amp/validator/parser/AMPHtmlParserTest.java

@GeorgeLuo GeorgeLuo mentioned this pull request Apr 1, 2020
Closed
rcebulko
rcebulko approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't have OWNERS approval here

@honeybadgerdontcare honeybadgerdontcare removed the request for review from Gregable April 4, 2020 00:00
@honeybadgerdontcare honeybadgerdontcare merged commit 1425757 into ampproject:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

@rcebulko rcebulko rcebulko approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GeorgeLuo @honeybadgerdontcare @rcebulko @googlebot