Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct host and hostname for url-replacement #2754

Merged
merged 1 commit into from Mar 30, 2016
Merged

Use the correct host and hostname for url-replacement #2754

merged 1 commit into from Mar 30, 2016

Conversation

mkhatib
Copy link
Contributor

@mkhatib mkhatib commented Mar 30, 2016

Fixes #2572

jridgewell
jridgewell reviewed Mar 30, 2016
View reviewed changes
spec/amp-var-substitutions.md
@@ -54,6 +64,16 @@ For instance:
```html
<amp-pixel src="https://foo.com/pixel?host=CANONICAL_HOST"></amp-pixel>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should include port number? Edit: Duh, the line underneath.

@jridgewell
Copy link
Contributor

LGTM.

@mkhatib mkhatib merged commit ed7ceff into ampproject:master Mar 30, 2016
@mkhatib mkhatib deleted the host-v-hostname branch March 30, 2016 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jridgewell jridgewell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkhatib @jridgewell