馃殌 amp-actions hide() can skipRemeasure #27654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
requested review from
jridgewell and
dreamofabear
and removed request for
kevinkimball
samouri
changed the title
|
Thanks for marking this work with the "Performance Improvements" project. Much appreciated. |
kristoferbaxter
approved these changes
Apr 8, 2020
dreamofabear
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Recently, I've added support to
mutator-impl.mutateElementto skip the remeasurement of an element in cases we know that it is unnecessary. I believe I've found another (albeit less significant) case.The
hide()action callsmutateElement, but I believe it then performs its own measurements withincollapseElement(e.g. sets it all to 0, sincedisplay:none). It then sets relayoutTop and schedules a new pass.