馃悰 .show() for iOS and autofocus must always remeasure #27729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
changed the title
dreamofabear
approved these changes
Apr 14, 2020
jridgewell
approved these changes
Apr 14, 2020
|
Tests for this are passing locally for me. Something weird is happening :/ |
samouri
force-pushed
the
opt-show
branch
2 times, most recently
from
93556b7
to
f5fb0f4
Compare
|
Giving up on figuring out why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
When showing a hidden element, we must remeasure that element as well as everything below it (via
relayoutTop). I just found an edge case where we miss the remeasurement, which would cause all the elements below the shown one to have stale (and incorrect) measurements.The bug only strikes if all three conditions are met:
.show()with a target that is not an amp element (e.g. a div)autofocus